Consider more nodes as ttPv nodes. #5819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-format 18 needs to be run on this PR. (execution 12966045048 / attempt 1) |
|
Because this marks more nodes as ttPV and the tests scaled not good i will check a non-regression at VLTC to check if it effect the ttPv reductione rule which was effects especially long TCs. EDIT: |
locutus2
force-pushed
the
tweak_ttpv6_pr
branch
from
2d6da3a to
4e4768d
Compare
Remove depth condition in propagation rule for ttPv state from a node to it childs. Because this change marks more nodes as ttPv, we have a time sensitive ttPv reduction rule and the STC snd LTC seems to show bad scaling. So i have also submitted a VLTC non-regression to check the scaling at higher time control. The results gives a little indication that we have perhaps good scaling with more ttPv nodes so that could be further explored. Passed non-regression STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 82528 W: 21627 L: 21453 D: 39448 Ptnml(0-2): 317, 9809, 20891, 9877, 370 https://tests.stockfishchess.org/tests/view/678e608cd63764e34db49ad7 Passed non-regression LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 310440 W: 78879 L: 78956 D: 152605 Ptnml(0-2): 255, 34915, 84938, 34876, 236 https://tests.stockfishchess.org/tests/view/678fab89ac8f8f5496155f3c Passed non-regression VLTC for scaling verification: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 59496 W: 15158 L: 14983 D: 29355 Ptnml(0-2): 15, 6039, 17470, 6204, 20 https://tests.stockfishchess.org/tests/view/6794bd1f4f7de645171fb33b Bench: 1498882
locutus2
force-pushed
the
tweak_ttpv6_pr
branch
from
4e4768d to
260cba3
Compare
|
The VLTC passed fast (less then 60K games which was the fastet from the three tests). So we have no issue. Perhaps we have even a good scaling for increasing ttPv nodes. |
vondele
added
simplification
xu-shawn
pushed a commit
to xu-shawn/Stockfish
that referenced
this pull request
Feb 2, 2025
Remove depth condition in propagation rule for ttPv state from a node to it childs. Because this change marks more nodes as ttPv, we have a time sensitive ttPv reduction rule and the STC snd LTC seems to show bad scaling. So i have also submitted a VLTC non-regression to check the scaling at higher time control. The results gives a little indication that we have perhaps good scaling with more ttPv nodes so that could be further explored. Passed non-regression STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 82528 W: 21627 L: 21453 D: 39448 Ptnml(0-2): 317, 9809, 20891, 9877, 370 https://tests.stockfishchess.org/tests/view/678e608cd63764e34db49ad7 Passed non-regression LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 310440 W: 78879 L: 78956 D: 152605 Ptnml(0-2): 255, 34915, 84938, 34876, 236 https://tests.stockfishchess.org/tests/view/678fab89ac8f8f5496155f3c Passed non-regression VLTC for scaling verification: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 59496 W: 15158 L: 14983 D: 29355 Ptnml(0-2): 15, 6039, 17470, 6204, 20 https://tests.stockfishchess.org/tests/view/6794bd1f4f7de645171fb33b closes official-stockfish#5819 Bench: 1829507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove depth condition in propagation rule for ttPv state from a node to
it childs.
Because this change marks more nodes as ttPv, we have a time sensitive
ttPv reduction rule and the STC snd LTC seems to show bad scaling. So i
have also submitted a VLTC non-regression to check the scaling at higher
time control.
The results gives a little indication that we have perhaps good scaling
with more ttPv nodes so that could be further explored.
Passed non-regression STC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 82528 W: 21627 L: 21453 D: 39448
Ptnml(0-2): 317, 9809, 20891, 9877, 370
https://tests.stockfishchess.org/tests/view/678e608cd63764e34db49ad7
Passed non-regression LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 310440 W: 78879 L: 78956 D: 152605
Ptnml(0-2): 255, 34915, 84938, 34876, 236
https://tests.stockfishchess.org/tests/view/678fab89ac8f8f5496155f3c
Passed non-regression VLTC for scaling verification:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 59496 W: 15158 L: 14983 D: 29355
Ptnml(0-2): 15, 6039, 17470, 6204, 20
https://tests.stockfishchess.org/tests/view/6794bd1f4f7de645171fb33b
Bench: 1498882